fix: Fix macOS keychain prompt in latest Electron#1396
Merged
Conversation
timfish
changed the title
andreiborza
approved these changes
Jun 30, 2026
nicohrubec
approved these changes
Jun 30, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
- Use a dynamic dispatcher in beforeEach so ignoreOrder is checked at event-receive time rather than server-creation time (before the test callback has had a chance to call ignoreExpectationOrder()) - Reset all mutable state at the start of the test body so vitest retries start clean instead of inheriting a rejected completePromise - Add ignoreExpectationOrder() to browser-profiling-trace because profile_chunk arrives before transaction on Windows Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The previous impl passed function matchers into expect.arrayContaining() which treats them as literal values (reference equality), so the check always failed for tests like session-native-crash-main that use function matchers to capture cross-event state (firstSessionId). Replace with a greedy matching loop: for each received event (in arrival order), find the first expectation that passes when called or toEqual'd. Processing in arrival order preserves the dependency order for function matchers that have side-effects (e.g. capturing a session ID in the first handler and verifying it in a later one). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no easy way to test this. Our CI test's didn't even pick up the issue.